Conversation
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
@hugomrdias all files seem to be exporting all constants and codecs in One more question: are the types automatically generated by the release command? Didn't see any information. |
hugomrdias
left a comment
There was a problem hiding this comment.
left some comments everything else looks good
i dont understand what you mean, are you talking about the .d.ts ? bundle size is not affected by this.
yes plus docs based on the types, |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
@hugomrdias just updated according to your comments. However, the generation of the docs fail: Looking at And this causes the error: |
|
humm it should work check this https://multiformats.github.io/js-multihash/index.html |
|
ah got it, define the |
|
@hugomrdias unfortunately, the same error persists |
src/base-table.js
Outdated
There was a problem hiding this comment.
this will cause the error you are seeing, use the types in types.ts instead
There was a problem hiding this comment.
If I use types.ts, then it will complain it's a recursive dependency, because types.ts gets the types from base-table. I'm separating them now. I'll need to generate two files this way anyways.
There was a problem hiding this comment.
The commit I just pushed works! not pushed...
There was a problem hiding this comment.
ahhh right thats why i just ignore this type in multihash https://github.com/multiformats/js-multihash/blob/master/src/constants.js#L16 😱
hugomrdias
left a comment
There was a problem hiding this comment.
LGTM but i would call types.ts -> generated-types.ts and add a comment at the top saying "DO NOT CHANGE THIS FILE ITS AUTOGENERATED by blal blah"
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>





That ^